This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Live location sharing: create beacon info event from location picker #8072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 16, 2022 17:50
Signed-off-by: Kerry Archibald <[email protected]>
Signed-off-by: Kerry Archibald <[email protected]>
Signed-off-by: Kerry Archibald <[email protected]>
Signed-off-by: Kerry Archibald <[email protected]>
Codecov Report
@@ Coverage Diff @@
## develop #8072 +/- ##
===========================================
+ Coverage 27.12% 27.14% +0.02%
===========================================
Files 868 868
Lines 52097 52113 +16
Branches 13199 13204 +5
===========================================
+ Hits 14130 14148 +18
+ Misses 37967 37965 -2
|
turt2live
approved these changes
Mar 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With: matrix-org/matrix-js-sdk#2245
Creates a beacon_info event with a default 5min timeout
Screen.Recording.2022-03-17.at.13.11.37.mov
Done:
m.beacon_info.*state events.m.beacon_info.*events in room stateuserroom has live beacons' property in room stateIn this PR:
In next PRs:
m.beaconevents for live beaconsisLiveon event content)This PR currently has no changelog labels, so will not be included in changelogs.
A reviewer can add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is, or addType: [enhancement/defect/task]to the description and I'll add them for you.Preview: https://pr8072--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.